-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google drive tool: new endpoint for google drive tool auth deletion #654
google drive tool: new endpoint for google drive tool auth deletion #654
Conversation
|
d35eb25
to
ea3e8e2
Compare
The new endpoint currently returns |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
Coverage 74.58% 74.58%
=======================================
Files 256 258 +2
Lines 11057 11136 +79
=======================================
+ Hits 8247 8306 +59
- Misses 2810 2830 +20 ☔ View full report in Codecov by Sentry. |
d6417c2
to
49b6563
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small requests
8e2631a
to
53b0242
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one comment and would appreciate it if you could add a couple of unit tests
a33aef2
to
bad911b
Compare
bad911b
to
f24d8ff
Compare
…ss, moved tool_id to path parameter
…eteToolAuth response
f24d8ff
to
2f9d084
Compare
Description
This PR adds a new endpoint which handles deleting google drive tool auth.
HTTP Request Method:
DELETE
Path:
/v1/tool/auth
Request Body:
Note that currently, the only supported
tool_id
isgoogle_drive
.Expected Response:
Issue
fix TLK-875
Dependencies
None
TODO
AI Description
This PR introduces a new endpoint for deleting tool authentication and updates the
GoogleDriveAuth
class to include adelete_tool_auth
method.Summary
The changes in this PR allow for the deletion of tool authentication, specifically for Google Drive. The new endpoint,
/tool/auth
, is added to the router insrc/backend/routers/auth.py
. It defines the logic for removing the corresponding ToolAuth from the database for the requesting user. Additionally, theGoogleDriveAuth
class insrc/backend/tools/google_drive/auth.py
is updated to include adelete_tool_auth
method, which handles the deletion process.Changes
/tool/auth
, for deleting tool authentication.delete_tool_auth
method in theGoogleDriveAuth
class.